Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do some minor formatting tweaks #1904

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Do some minor formatting tweaks #1904

merged 4 commits into from
Oct 1, 2023

Conversation

peternewman
Copy link
Member

@peternewman peternewman commented Sep 19, 2023 •
edited
Loading

To reduce the diff before lots more significant changes appear...

View it here to simplify it further:
https://github.com/OpenLightingProject/ola/pull/1904/files?w=1

@peternewman peternewman added this to the 0.11.0 milestone Sep 19, 2023
@peternewman peternewman requested a review from kripton September 19, 2023 18:08
kripton
kripton approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@kripton kripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I dislike leaving out the curly braces on one-instruction conditions. Took me a while to review since when I first looked at it, I had the impression you changed the logic at one location. But looking at it closer now, it's all harmless changes 👍

@peternewman peternewman merged commit 486cae1 into OpenLightingProject:master Oct 1, 2023
10 checks passed
@peternewman
Copy link
Member Author

Very good. I dislike leaving out the curly braces on one-instruction conditions.

Yeah I've been caught out with it a few times before hence trying to remove them.

Took me a while to review since when I first looked at it, I had the impression you changed the logic at one location. But looking at it closer now, it's all harmless changes 👍

Ah that's odd. Anyway glad you're happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripton kripton kripton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@peternewman @kripton